Ulrich Sossou comments

Results 19 comments of


                                            Ulrich Sossou

Added a 'indicators' option similar to the bootstrap carousel

@rhertogh noticed that. no worries :)

Added a 'indicators' option similar to the bootstrap carousel

I'm wondering if there's a better way to handle the indicators template. Cc @ousram @brexis

Pull request: many features and fixes added

Thanks for your contribution @IGreatlyDislikeJavascript . Using CoffeeScript made sense when the plugin was just released. I'm looking to move it to ES6 but don't have time to do that...

Bootstrap 4

@aeksco of course, we want to make this project Bootstrap 4 compliant. Are these the only changes needed for compatibility?

Bootstrap 4

It looks like rem question is not settled yet https://github.com/twbs/bootstrap/issues/19943.

Ok. Thanks! I think we can make these changes backward compatible: - Migration from LESS to SCSS / Leverage $border-radius and $enable-rounded variables for .tour-step-background CSS People currently importing the...

Bootstrap 4

The latest version in master should be compatible with Bootstrap, except for the `orphan` option.

getCurrentStep in onShow method returns 0 for first two steps

@ousram please can you verify this?

Refactoring and option for skipping pull requests

Thanks! Please can you fix the merge conflicts?

Enable regExp for step host option

@brexis, is this good for merging?