Sophie Alpert
Sophie Alpert
Yeah, I figured as much. Maybe we could just special-case the first comment? It seems rare that you'd ever want to move or drop it (especially at FB).
300 MB and 800 MB still sound pretty different. :) Would be neat to see a comparison of all the alternatives if you ever revisit this.
This looks to be the same as #24649 so let's consolidate there.
> RegExp: These are pretty straightforward but can possibly have security implications. What's the security risk here?
I think the biggest issue is fonts. There are no Computer Modern versions of those characters, right?
hi @Biki-das — in a future React release we'll likely add React event listeners directly to DOM nodes so we would inherit the browser behavior with no additional work. it...
In your PR description, what is the `if (errorMessage != null) {` for?
@malyzeli Thanks, fixed.
Check out how react-art’s Surface component works. In particular, pass a class component’s “this” value to updateContainer: https://github.com/facebook/react/blob/master/packages/react-art/src/ReactART.js Hope that helps.
If I’m not mistaken, this line is meant to catch if the store was mutated in between render and subscribe (if we were not already subscribed to the store at...