David Testé
David Testé
*[`.github/workflows/benchmark_gpu.yml` line 78 at r2](https://reviewable.io/reviews/zama-ai/tfhe-rs/2292#-OOhatg51_-0kEL1zyjn:-OOhlIum3K2zsDDOo4th:b-vfq0h6) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/df9cfd98c5f6d8456d64e379ed66b025ed98dfec/.github/workflows/benchmark_gpu.yml#L78)):* Previously, IceTDrinker (Arthur Meyre) wrote… `$?` is the exit code ? Hmm you're right, I've to find another way to do what I...
*[`.github/workflows/benchmark_gpu.yml` line 99 at r2](https://reviewable.io/reviews/zama-ai/tfhe-rs/2292#-OOhb7SrEuY70QVS1mSk:-OOhlutG18BAn90H76iS:b-lxin0d) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/df9cfd98c5f6d8456d64e379ed66b025ed98dfec/.github/workflows/benchmark_gpu.yml#L99)):* Previously, IceTDrinker (Arthur Meyre) wrote… this is a way to restrict secret access ? What do you mean ?
*[`.github/workflows/benchmark_shortint.yml` line 123 at r2](https://reviewable.io/reviews/zama-ai/tfhe-rs/2292#-OOhc5kc1J4fR_JzE51r:-OOhm116A0BTwsDPVGYu:b2nhll9) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/df9cfd98c5f6d8456d64e379ed66b025ed98dfec/.github/workflows/benchmark_shortint.yml#L123)):* Previously, IceTDrinker (Arthur Meyre) wrote… don't use env. when it's an env var, use the ${} expansion directly Ok.
*[`tfhe-benchmark/src/params_aliases.rs` line 173 at r1](https://reviewable.io/reviews/zama-ai/tfhe-rs/2236#-OMvmQ5F0ANiqv4S7T-p:-ON0D_tsAYUSZO4R4b0r:b-yx5cql) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/b171eb3bd8e532bdeb8e8e3b91b8f732fa91ad9d/tfhe-benchmark/src/params_aliases.rs#L173)):* Previously, agnesLeroy (Agnès Leroy) wrote… Don't we miss ZKV2 here? The ones look-alike without ZKV* in their name, are ZKV2 by default.
*[`tfhe-benchmark/src/params_aliases.rs` line 178 at r1](https://reviewable.io/reviews/zama-ai/tfhe-rs/2236#-OMvmSHe3oQcM99axpeh:-ON0DnEU5FFUBoR5qytd:b-723q8b) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/b171eb3bd8e532bdeb8e8e3b91b8f732fa91ad9d/tfhe-benchmark/src/params_aliases.rs#L178)):* Previously, agnesLeroy (Agnès Leroy) wrote… We probably need these as well no? They're not used at the moment in the benchmarks.
PR on hold waiting for a big code merge to come.
Here's a successfull run: https://github.com/zama-ai/tfhe-rs/actions/runs/19339733752?pr=2999