David Testé

Results 27 comments of David Testé

> probably a check missing to not start instances at all if no file changed You're right. Have to fix this.

> What do you mean by local ? You can run them on your laptop if you want but its not really going to be meaningfull especially for the thourhgput...

@IceTDrinker I'll you review this since I've added some code.

> Looks generally ok minor comments, did we do a run of the bench workflow to check it works properly @soonum ? I can do that, I just have to...

Workflow tested with success.

> @soonum this will break things in Grafana in the core crypto page as the parameter names change I think. Plus we won't be benchmarking some parameters we used to....

*[`.github/workflows/approve_label.yml` line 10 at r1](https://reviewable.io/reviews/zama-ai/tfhe-rs/2292#-OOh_nwTEEtFZSAuwFge:-OOhkU-i4FzRvbAz1a4J:bv805ha) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/032a1c9c08d183ee5e46df5078606c964e47491f/.github/workflows/approve_label.yml#L10)):* Previously, IceTDrinker (Arthur Meyre) wrote… what are empty permissions ? This blocks all permissions for GITHUB_TOKEN, which are very (very) broad by default.

*[`.github/workflows/aws_tfhe_backward_compat_tests.yml` line 90 at r1](https://reviewable.io/reviews/zama-ai/tfhe-rs/2292#-OOh_sv3CefvLHSTnsWY:-OOhkgQB3pciixVTs-_E:bb74ce2) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/032a1c9c08d183ee5e46df5078606c964e47491f/.github/workflows/aws_tfhe_backward_compat_tests.yml#L90)):* Previously, IceTDrinker (Arthur Meyre) wrote… replace the ${{ env.REPO\_URL }} by ${REPO\_URL}, also make sure it is quoted ? or maybe replace by...

*[`.github/workflows/aws_tfhe_backward_compat_tests.yml` line 108 at r1](https://reviewable.io/reviews/zama-ai/tfhe-rs/2292#-OOh_wJc4pH3YWBF-lDd:-OOhkjlKC45N2wa_EZ5B:b-6fiwv3) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/032a1c9c08d183ee5e46df5078606c964e47491f/.github/workflows/aws_tfhe_backward_compat_tests.yml#L108)):* Previously, IceTDrinker (Arthur Meyre) wrote… ${{ secrets.CHECKOUT_TOKEN }} ? Nope, look in the top-level `env` directive. I did it that way to deal...

*[`.github/workflows/aws_tfhe_backward_compat_tests.yml` line 131 at r2](https://reviewable.io/reviews/zama-ai/tfhe-rs/2292#-OOhaY380FXAxTPkTjxR:-OOhkypMEqPjb4MSy17t:brep76s) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/df9cfd98c5f6d8456d64e379ed66b025ed98dfec/.github/workflows/aws_tfhe_backward_compat_tests.yml#L131)):* Previously, IceTDrinker (Arthur Meyre) wrote… what's vars ? It's an environment variable set up at the repository level (like any secrets) but it...