Christopher Morton

Results 15 comments of Christopher Morton

If the exercise is to remain in its current state, an additional instruction needs to be added to the `README.md`. For example: "Omit all other non alphanumeric characters".

I am leaving this issue unresolved until the documentation for the type has been written. Thank you @LeoniePhiline for the starter PR.

Nice catch! Thanks for your pull request, and for your patience.

Thank you for raising this! There will likely be a new `dotenvy` API before the 2024 edition is stable; so `set_var` becoming unsafe will certainly influence it. For now, I...

This is what I have come up with for the rustdoc. @allan2 could you please review it? ### Safety Even though this function is currently not marked as `unsafe`, it...

Unfortunately this is going to apply to _every_ public function as they all internally call `set_var`. Particular care will be needed with the `_iter` functions. They are safe until `Iter::load`...

Proposed `README` addition: --- ## Safety The majority of `dotenvy`'s _existing_ API will be marked as unsafe when the 2024 Rust edition is stabilized. The functions modify the environment, which...

> On the Rust community discord, @5225225 suggested the idea of a `#[tokio::main]`-style attribute macro that inserts the necessary call to the unsafe load function as the very first thing...

I think we should add a safety notice now for the existing API. @allan2 would you be OK with me adding the rustdoc and readme additions above?

We are currently redesigning the API to allow for more extensible configuration. A builder pattern is likely to be part of it. In the meantime, variable substitution is the same...