Sonny Piers

Results 502 comments of Sonny Piers

The issue template has the following line > Share logs using https://github.com/xmppjs/xmpp.js/tree/main/packages/debug It's not optional, specially to debug an issue like this :)

Thanks, can you please refer to the spec in the code/PR and adjust accordingly if needed? A test is also needed https://github.com/xmppjs/xmpp.js/blob/main/CONTRIBUTING.md#making-changes

To be honest I'm not too sure why we should protect against misbehaving servers. XMPP assumes the server is trust worthy. If XMPP.js was to start adding safeguards for every...

Thanks for taking the time to elaborate and consider various positions. I would consider merging this if there was a known server impl behaving like so. > If xmpp.js is...

Tests should be updated so that a test would fail before the fix and pass after the fix. The best way to do that is to add a new test...

ie - don't call `send` or `write` if you're not connected

We'll need to find with certainty the source of the exception. Then understand why it is uncaught. A good starting place is to check if a stream feature throwing results...