xmpp.js icon indicating copy to clipboard operation
xmpp.js copied to clipboard

Don't allow pings to prevent timeout

Open singpolyma opened this issue 9 months ago • 3 comments

Sending a new request shouldn't clear the waiting-for-reply timeout if we haven't got a reply yet, or else we may never time out at all if we keep sending pings (which we do).

singpolyma avatar Feb 19 '25 19:02 singpolyma

fixed the test

singpolyma avatar Feb 19 '25 20:02 singpolyma

Tests should be updated so that a test would fail before the fix and pass after the fix. The best way to do that is to add a new test that describes the issue for example "Pings do not preven timeouts"

sonnyp avatar Jun 11 '25 08:06 sonnyp

Tests should be updated so that a test would fail before the fix and pass after the fix.

Yes, that's what I did. The test previously had a too-long interval so it was over before this case would even trigger and so would pass. As now written it fails without this change and passes with this change.

singpolyma avatar Jun 11 '25 14:06 singpolyma