Sonya Nikiforova

Results 86 comments of Sonya Nikiforova

By the way, along with the tests, this change has also broken the Linter GH Action - but it's only visible when we are committing Markdown files. One of the...

> @sonniki I still get this glitching behavior. One line in the golden shows up at different points on different computers. I think it's a race in the OS itself,...

Linter GH Action was still [throwing an error](https://github.com/causify-ai/helpers/actions/runs/14473917294/job/40594697250?pr=564) because of an invalid tmp file path for running `prettier`. I did a quick fix in #570 to unblock (reverting to the...

Here are the necessary links: - https://github.com/causify-ai/helpers/blob/master/docs/coding/all.developing_linter.how_to_guide.md - https://github.com/causify-ai/helpers/blob/master/docs/coding/all.amp_fix_md_links.explanation.md - https://github.com/causify-ai/helpers/blob/master/linters/amp_fix_md_links.py - https://github.com/causify-ai/helpers/blob/master/linters/test/test_amp_fix_md_links.py We want to fix the bug and add unit tests.

> [@sonniki](https://github.com/sonniki) > > I implemented both of the suggestions you mentioned. I first checked if the file existed by removing the text after the `#`. Next, if the file...

Replacing manually and only in links to GH pages would be enough here

> @sonniki how about we use this issue as a catch all issues posting examples of what needs to be automated in code reviews I'm currently compiling a big bullet...

The doc with the guidelines that cover a lot of common review comments is now checked in at [`docs/code_guidelines/all.automated_review_guidelines.reference.md`](https://github.com/causify-ai/helpers/blob/master/docs/code_guidelines/all.automated_review_guidelines.reference.md)