Sonya Nikiforova

Results 86 comments of Sonya Nikiforova

The usual flow is 1) Create unit tests to reproduce the problem (the general Linter test file is [`linters/test/test_amp_dev_scripts.py`](https://github.com/causify-ai/helpers/blob/master/linters/test/test_amp_dev_scripts.py) although it would be best to put the unit tests in...

This solution is fine if nothing else works, but just wondering, do we know why it's happening with these code blocks but not the others?

So the conclusion is that we'll turn "\```markdown" into "\```text" (for example), and problem solved?

I would go for the "text" solution, and make this a test in `linters`. @sandeepthalapanane as a note in general, you don't have to confirm all of your decisions. In...

> We encountered some formatting issues in the docstring of a function when the linter was run on the following file. This is non-blocking, as we can simply revert and...

> I've filed a similar bug. Not sure if it's fixed already. In any case, let's file bugs, rather than catch all to make things more visible. It has indeed...

Not very useful atm; closing

> TODO(gp): Make sure the S3 dir exists. Interns don't have access to our `s3` buckets, so it would be hard for them to debug. I'd say this one can...

The fix from @heanhsok is good, thank you for jumping on to fix the build. As a side note, I don't understand why we had to disable the option in...