Soumyava
Soumyava
@pjain1 I have started taking a look at this PR. Deepest apologies that it has not been reviewed yet. Any chances, you can help resolve the conflicts ?
@pjain1 thanks, I have resolved some conflicts and have made this PR up-to-date. #12750 has the changes. I'll appreciate if you can help add to it and review it
I'll add in the documentation shortly after I orchestrate the test changes and get past some of the travis failures
@zachjsh this PR is just a refactoring of #10407. I have updated the description from there in this as well so to keep all info at one place. I'll add...
Travis is failing from a branch coverage from the changes to `BaseLeafFrameProcessor`. While I am working on that I am setting this PR up for review now.
Guice issues in Integration tests. Taking a look
@imply-cheddar , @clintropolis I have addressed the comments and also resolved the conflicts. The thing remaining to address it use of a set in `GuiceInjectableValues` so the nullable check can...
I have introduced an atomic reference to a set to not do the check on every run in `GuiceInjectableValues`. @clintropolis @imply-cheddar @abhishekagarwal87 this is ready for review. Can you please...
The conflicts have been resolved. Some additional refactoring introduced due to change in underlying test framework in #12965. CalciteTests do not have the `createDefaultJoinableFactory` anymore and all references for JoinDataSource...
I'll add the unit test. Seems like #13173 fixes this. The query under consideration is ``` select t1.__time from foo as t1 JOIN numFoo as t2 on t1.dim2 = t2.dim2...