Arved Solth

Results 210 comments of Arved Solth

Converted to "Draft" to incorporate change requests made by @subhhwendt

@thomaslow thank you for the remarks. I added some titles to the buttons as you suggested to hopefully make it easier to understand what each of them stands for. I...

> @solth We had a discussion on the implementation in the @kitodo/kitodo-community-board. Based on that we would like you to implement the following behaviors > > 1. It should be...

> I experimented with your changes a bit. I added the new permissions, imported a process from a catalog, changed a few metadata fields, and clicked the new "sync" button....

@BartChris @thomaslow @subhhwendt I added some checks incorporating the `minOccurs` and `maxOccurs` rules from the ruleset that should prevent selecting more or less metadata entries than allowed. This is done...

> After some testing we discovered some subtle bugs: > > 1. If a new metadatum (group or simple) is coming from the catalog and there is nothing on the...

> @solth During merging, I noticed that you forgot to add `groupDisplayLabel` to `Kitodo-DataEditor/src/test/resources/ruleset.xsd`. Thanks for pointing this out. I opened a pull request to add this element to the...

@thomaslow Maybe now would be a good idea to check again whether multi-drag-n-drop works as intended, since Primefaces has been updated in the `main` branch?

> @solth Unfortunately, the relevant bug that lead to the decision to disable multi drag-n-drop was only fixed in PrimeFaces 13.0.5, see [original comment](https://github.com/kitodo/kitodo-production/pull/6340#issuecomment-2672270768). Yes, you are right, I forgot...

If backwards compatibility for existing bookmars etc. _with_ the `.jsf` extension is required, this could perhaps be achieved using the Tomcat "rewrite valve" functionality: https://tomcat.apache.org/tomcat-9.0-doc/rewrite.html