Arved Solth

Results 220 comments of Arved Solth

> Why is the column layout so important that there needs to be a special message to the user (in contrast to other features of the metadata editor that also...

> @solth : What do you think about? The menu is a good idea, so I am all for it! We should also consider adding a button that _removes_ the...

@andre-hohmann sorry, I saw your comment too late. I already merged the pull request from @thomaslow. If you think the growl message should be removed that's absolutely fine with me....

> I created a mockup, for a possible marking on the wrench button: > ![dataeditorsettings_1](https://private-user-images.githubusercontent.com/32509444/385024410-fc7722c1-1799-4899-9036-d2a4ee06445a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzEzNDk5OTYsIm5iZiI6MTczMTM0OTY5NiwicGF0aCI6Ii8zMjUwOTQ0NC8zODUwMjQ0MTAtZmM3NzIyYzEtMTc5OS00ODk5LTkwMzYtZDJhNGVlMDY0NDVhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTExVDE4MjgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBiYWNlOTM0NWFiODNkOTUzMmJlYTlhM2VlY2UyNzgxMWMxNWJmNTgyZjViMWQ5MWM0MGJlMDdlZTgxYzUxMTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.1Z5Aqc9jl5c6d3gvFqMIWOo5SD7khzUr4ojN8rgXlvI) > ![dataeditorsettings_2](https://private-user-images.githubusercontent.com/32509444/385024449-ee495a29-fc28-4c0e-bf16-e9d365f6a621.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzEzNDk5OTYsIm5iZiI6MTczMTM0OTY5NiwicGF0aCI6Ii8zMjUwOTQ0NC8zODUwMjQ0NDktZWU0OTVhMjktZmMyOC00YzBlLWJmMTYtZTlkMzY1ZjZhNjIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTExVDE4MjgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNmYTFiNmNjMTM2MDI0ODViMDg1MzhjYWUwODUzNWI3ZGEwZDk4NTFjZTlhNTBmYmU0ZTQzYjI3YjYxOGZhZGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zazsiknTSHQ6lmC8BVjHn5AYRXXxLPrDQvP8bACy7AA) > These two icons could also give a hint on the type of...

I think this is a description of the effects of #3472, which also causes #3346

> @solth what would be needed for this to be merged? For starters, there are conflicts that need to be resolved before this pull request can be merged. Additionally, it...

@aetherfaerber would you or a colleague of yours be willing and confident to review this pull request? That includes checking the code as well as testing the functionality (which you...

@aetherfaerber thank you very much for your review. And sorry I forgot to reply to your question earlier. Those are the correct, current coding guidelines you mentioned, even though they...

@BartChris does this pull request resolve #4837 for you?

I agree with @BartChris that we should try to avoid code and method duplication as much as possible. Unfortunately, the various ways to import metadata into Kitodo has already resulted...