Arved Solth
Arved Solth
> We could use `ProcessService.canCreateChildProcess` for that. But i am not sure about the performance implications if we apply that here (it would be good, if Elasticsearch would allow us...
Also, wouldn't it be necessary to also check for `createChildrenWithCalendar` in addition to `createChildrenFromParent`, to be able to manually link newspaper issues?
> * The behaviour that the search in the Title Link tab only returns one result should probably be changed since in Kitodo 3.6 the software returns more than one...
> > > We could use `ProcessService.canCreateChildProcess` for that. But i am not sure about the performance implications if we apply that here (it would be good, if Elasticsearch would...
> Another thing which i already stumbled over in the old PR ([#5663 (comment)](https://github.com/kitodo/kitodo-production/pull/5663#issuecomment-1821226911)) but forgot again: We also need to apply the authority checks to the `ImportService.loadParentProcess` method, otherwise...
I have made the following adjustments: - the method `TitleRecordLinkTab.setParentAsTitleRecord` does not reset the list of `possibleParentProcesses` anymore (I can't see any reason why this would be done here in...
> **TLDR**: I support the current implementation and still think the implementation of the one outstanding TODO is necesary. But i think in generally we can move forward now. Great...
@BartChris thanks for the response. I just fixed a test so that the CI build is now succesfull. Would you mind checking whether or not you approve the current state...
@BartChris can you formally approve this PR or make change requests if you see something that should be adjusted _before_ merging?
> **I approve the Pull Request in the current form**. @BartChris Sorry, I thought you had the "Approve" button as in other pull requests when reviewing the changes in the...