Peter Solnica

Results 573 comments of Peter Solnica

Thank you for working on this but this has to wait. We're in the process of releasing dry-system 1.0.0 and then Hanami 2.0.0 and it's code freeze now. We'll get...

Even though I understand it might've been a "gotcha" for you, it's usually, well, it's always a good idea to call super if you override something :smiley: Anyway, I agree...

You _must_ specify `primitive` in custom attributes. Virtus looks up for the attribute based on the primitive which is the actual type you want to coerce to. Attribute subclasses are...

OK I will look into it

Yes this makes sense. Thanks for the hints. I'll see what I can do to quickly fix it.

That's a great suggestion On Thu, Oct 3, 2013 at 3:55 PM, mirasrael [email protected] wrote: > ## It may be better to use `attribute` as argument for `extend?` method, because...

No I'm not planning to work on it anytime soon. Would love to see a PR :) On Thu, Oct 3, 2013 at 4:04 PM, mirasrael [email protected] wrote: > ##...

@mirasrael thanks! that was fast :) I left some comments

This wouldn't be a regular way of using it but in a framework reality, where it controls what happens, this makes sense. An inflector could be exposed to anything that...

We can just use `freeze` yes. The most important thing is to allow setting up inflections outside of the inflector block. I don't remember why we ended up with finalize...