Peter Solnica

Results 573 comments of Peter Solnica

Yeah I'd be in favor of doing this even though it'd make things a bit more complicated on the config side. We could even capture all method calls that are...

Right. My only concern is that config object methods may potentially clash with logger methods. I wonder now if maybe using a provider for logger to tune the instance would...

Thanks Tim for chiming in ❤️ > I think using a custom logger provider makes sense but how do you suggest dealing with environments? At least with the application configuration,...

> By the way, I've been struggling with the use of target terminology Thanks for bringing this up, but let's not have this convo here as it's not strictly related...

Because you have two workers by default

Huh right, I didn't notice that it's `stop`. This does look weird. Hard to tell what's going on without debugging it first.

Should we then discard the default dev/test logger whenever a custom formatter is configured? The default dev/test logger is there for convenience, the common use case is that you want...

Thanks for the PR! So you're saying that without this, it's broken under 3.x?

> I think we can drop ruby 2.x safely Yes let's do this