Peter Solnica

Results 573 comments of Peter Solnica

Please rebase this against the latest master as your other PR got just merged 🙂

@zlw thanks, this is something we should definitely support. Personally I don't use engines at the moment, which means I won't be able to help with this other than to...

@flash-gordon do you know why this happens though? Was it on purpose?

For the record, this is probably caused by the fact that `Macros::Each` doesn't rewrite the current type using the `inner_schema`.

@flash-gordon yes, `JSON` is a `Processor` specialization, it supports adding arbitrary steps, it simply passes result-like objects from step to step, and can aggregate errors in this process. This means...

@aglushkov we can, but it looks like it would be a breaking change. I *think* it should be possible to use [a custom type container](https://dry-rb.org/gems/dry-schema/advanced/custom-types/) to override json's `float` as...

I reckon we could have something like this @flash-gordon : ```ruby Dry::Schema.JSON(Array) do # do your thing end Dry::Schema.JSON do # do your thing end ```

Here's some food for thought: ```ruby require 'dry/schema' Dry::Schema::ProcessorSteps.prepend(Module.new { def call(result) catch(:halt) { super } result end }) class Dry::Schema::MessageCompiler def visit_unexpected_input(node, opts) input, * = node Dry::Schema::Message.new( path:...

@flash-gordon we can have `result.halt` that just sets it internally to a failure state and further processing won't happen