Gunter Labes

COMP_WORDS: bad array subscript

3

I get the error from the title with `var= ./do ;` when attempting tab completion at the indicated position. https://github.com/scop/bash-completion/blob/f5756939a45e5da774274293768da2d7e547d8c4/bash_completion#L2276-L2280 `"${COMP_WORDS[-1]}"` is used in the else case even when `COMP_WORDS`...

Error out if data dir is not found automatically

2

### Describe the desired feature Currently you get an assert that's not very clear about what the issue is: https://github.com/wesnoth/wesnoth/blob/bc94f37f767960f053ff5f77cc5cf3b5100042a1/src/filesystem.cpp#L1497 Better would be to error out if no data dir...

map diff tool fails on certain terrain and images are swapped

1

The map diff tool fails on maps with `_off^_usr` terrain as visible in this run: https://github.com/wesnoth/wesnoth/runs/7301694657?check_suite_focus=true It would be good if there would be an error message if it doesn't...

Remove shell injection in example

3

### Why: Avoid shell injection in workflow example. ### What's being changed (if available, include any code snippets, screenshots, or gifs): Workflow example ### Check off the following: - [...

Avoid shell injection in examples

5

### Why: Avoid shell injection in examples to follow suggestions from https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections. ### What's being changed (if available, include any code snippets, screenshots, or gifs): Changed examples that used shell...

Correct message level documentation

6

I'll also check level usage in examples. In https://github.com/irssi/irssi/blob/07b971cf0c5a6607f9071f332ae27adb3bb4baa1/src/core/levels.c#L25-L49 there is also PUBNOTICES listed ~~which is not mentioned. Not sure if that should also be added to the help.~~

Confusingly named /ignore option -pattern

1

The option description: > -pattern: The text pattern to ignore. First sentence of the /ignore command description: > Ignores nicknames or text that matches a pattern. Yet as far as...

[remove_unit_overlay] issue

19

https://github.com/wesnoth/wesnoth/commit/b2cd1cf made [remove_unit_overlay] use an object_id key and unlike [unit_overlay] does not fall back to "overlay_" + image. At least the UNMAKE_HERO macro uses [remove_unit_overlay] without object_id. I've added minimal...

Improve design of [filter_ability] and [filter_ability_active]

7

### Describe the desired feature Instead of having two tags this should be one tag that supports filtering on active status and type. So something like ``` [filter_ability] active =...

Sync man page and --help output

18

### Describe the desired feature It would be nice if man page and --help output would be more in sync. For example --help output has no useful argument names. (Now...