Samir Shah

I can see how this would be useful. We don't currently have a canonical set of thumbnail sizes (there's a somewhat arbitrary variety used in the various templates, often resulting...

I feel like https://github.com/django-oscar/django-oscar-invoices might already be addressing this use case - and if it isn't then extending it to do so might be a good approach.

Hey @MLI-DS thanks for this - I think it would make a very useful addition to the core. The approach and app structure you've proposed looks good to me -...

> Did you have something more specific in mind? No, I think what you've proposed works, just wanted to state it explicitly. > What particular difficulties could be faced when...

I'm not able to reproduce this on the sandbox. What browser are you using, and are you sure you've not got any custom styling that overrides the default?

I think type hinting will be useful to developers working with Oscar, and would support your efforts to work on it! That said, Oscar's dynamic class loading is potentially going...

@sasha0 this is a good start - a few comments: 1. We can't use `apps.is_installed()` to check whether an oscar app is installed - that will not work with forked...

@samitnuk your proposed approach makes sense to me. We'll have to properly document this in the release notes for projects that have forked either the basket or the voucher app.

@jayvdb I think there's a legitimate argument for disabling the middleware for the django admin, which we can give some thought to. However, the exception you have posted doesn't appear...

Looking at this more closely it seems the underlying issue is that there is a reference to a proxy benefit/condition class that no longer exists. Oscar could probably handle that...