Results 84 comments of Samir Shah

@SakshiUppoor I think it would be good to add tests to `tests/integration/dashboard/test_offer_views.py` to verify that this functionality works as expected. Would you be able to do that?

Thanks for your detailed report. We are aware that support for Django 4 is missing - unfortunately this is currently blocked by some of the packages that Oscar depends on...

See [my comment here](https://github.com/django-oscar/django-oscar/pull/3868#issuecomment-1067495683) which I think applies to these fields as well - this is a deliberate decision to aid migration of data.

I'm happy to make Partner name unique - PR welcome. Thanks!

Hey @JamieSlome thanks for reaching out. While we work on putting in place a security policy I'd be grateful if you (or @ktg9) could drop me an email (contact in...

I don't really have an issue with the metapackage approach. My main question would still be what the value of a totally unpinned package is? If you try to install...

Hmm. `pip` will still install the package using `setup.py` (not `metasetup.py`) which means that even if you install the "safe" package you end up with unpinned dependencies. This is why...

@craigloftus @sasha0 thoughts?

> Also we need to think about the case when basket is disabled within the view, but called in the templates. Easiest approach I have in mind is to throw...

Looking at the history of that code I can't see any obvious reason why it was implemented in that way. I agree with you that using a foreign key would...