Solar Designer

> See the `-Xclang -fopenmp` at https://github.com/openwall/john-packages/blob/main/scripts/ci_controller.sh#L97. Should we possibly get this into the main project here, perhaps as a change to `configure.ac`? Would you test and contribute? When linking...

> the default benchmark being for a mix of two different cost settings is something we could want to fix, standardizing on one cost. Maybe what we have now isn't...

> 1. Why is `--enable-openmp-for-fast-formats` discouraged? (Which are the "fast formats"?) Those are implementations of hashes that are too fast for efficient scaling with our current use of OpenMP. We...

Patched to 125, still works (using a CMIYC 2024 hash on an ancient machine): ``` $ ./john -mask='Adity?l?s?d?d?d?d' pw-argon2id Device 1: GeForce GTX 570 Using default input encoding: UTF-8 Loaded...

Thanks @alainesp. I just wanted to know you don't recall any special reason for choosing 100. I don't see any limitations in the code. Ideally, we'd actually test with a...

Reviewing the code, I see the password is processed on host only, in `argon2_initial_hash`, which does: ```c blake2b_update(&BlakeHash, (const uint8_t *)context->pwd, context->pwdlen); ``` So there's no issue with increasing the...

> bump this to our usual maximum of 125, unless there's any specific reason to keep it at 100 Yesterday, I realized that the 100 was copied over from the...

Thank you for reporting this! > It'll be great if we can add a small section in INSTALL.md for AMD GPU build: We don't currently have an `INSTALL.md`. We have...

Looks like you never said what version(s) of John you observed the problem and tested the fix with? > ```shell > ./configure LDFLAGS=-L/opt/rocm/lib CPPFLAGS=-I/opt/rocm/include > ``` `CPPFLAGS=-I/opt/rocm/include` shouldn't make a...

Also, if we find _any_ OpenCL library at build time, then the resulting build should work with whatever (maybe other) OpenCL library it sees at run time. So rather than...