Solar Designer

> @RecRanger Can you show how exactly the script doesn't work with the latest version of protobuf? @RecRanger I would still be interested in having such detail recorded in here,...

> > Testing: ZIP, WinZip [PBKDF2-SHA1 256/256 AVX2 8x2]... > > zip_fmt_plug.c:144:27: runtime error: index 64 out of bounds for type 'unsigned char[60]' > > This looks like a real...

> clang version 18.0.0 (https://github.com/llvm/llvm-project.git d50b56d18c96e0ce462d7236eb268c54098cbaf9) > Target CPU ......................................... x86_64 AVX2, 64-bit LE Also tried specifically `./configure CC=clang --enable-simd=avx2`. But my clang is much older.

I'm not into Python. I'd appreciate to hear from someone who is, @exploide maybe? Thank you!

> Also tried specifically `./configure CC=clang --enable-simd=avx2`. But my clang is much older. Adding `--enable-ubsan` to this, I get: ``` $ ../run/john -test=0 -form=zip Will run 4 OpenMP threads Testing:...

> Running this gets past the imports at least: `PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python run/multibit2john.py` Cool. Can you also try embedding the setting of this variable inside the script? Does `coinomi2john.py` also need this?...

I think we should add the `+ 0` workaround (and a source code comment) to allow testing of the rest of this code with UbSan. Re-opening for this.

> I guess we would at least need a comment in the code explaining why we set the variable. Yes, should have that comment.

Thank you for the review @exploide! I'm not sure what is best to do here. @RecRanger argues for this approach further in #5474. @RecRanger Thank you for the fix and...

> Probably, parentheses would also have fixed the issue. Moreover, this was the real issue! I'm embarrassed I didn't realize at first. So the only UbSan bug here is that...