Solar Designer

Thank you @claudioandre-br for these additional tests. > If you enable ASAN, no errors are seen: > If you remove the stack protection (to get another hint). I find these...

Thank you @kholia. It's great that you're still around! I don't recall all detail of this issue (was the issue disappearing with ASan for us?), but if you have time...

FWIW, the contents of `out` after the `pre_processing` kernel on Intel and AMD OpenCL on CPU match GPU's (so must be correct). On Intel HD Graphics, they don't match, so...

Overriding these didn't make a difference (still works on GPUs, fails on CPUs): ```c #define upsample(a, b) (((ulong)(a) > 32) ```

With the below hack and `shmemSize` forced to 32 KiB, it still works on a GPU, but still fails on CPUs like before: ```diff - uint warp = (get_local_id(1) *...

In #5420, @magnumripper shows a macOS system where the format works for the first few test vectors on HD Graphics (edit: specifically, on `Intel(R) UHD Graphics 630`), only failing at...

> if we do continue checking, then maybe check only for the library? We definitely don't need the headers anymore We no longer check the headers due to @claudioandre-br's #5398....

@claudioandre-br I really would like to have `--enable-opencl` at least for build-testing of changes to OpenCL host code on systems without OpenCL.

> I really would like to have `--enable-opencl` at least for build-testing of changes to OpenCL host code on systems without OpenCL. Also for `--fuzz` of OpenCL formats' hash parsing,...

@claudioandre-br Do you want to implement `--enable-opencl`, please? Looks like besides the reasons in my previous comments here, it'd also let us simplify the documentation. There would be no need...