Solar Designer

IIRC, this issue is supposed to be fixed by #203. Closing.

> Can you reproduce it? Can we have more verbose logs? Looks like LKRG is not being unload but completely different module It'll probably will take some stress-testing to reproduce...

Our current instructions in the "Installation" and "Uninstalling and upgrading" sections of `README` rely on the current behavior, and `make uninstall` would currently unload LKRG via: ```shell elif [ "$1"...

I think let's close for now. We can revisit later. We're considering additions to LKRG that could affect the decision-making here, so deciding on this issue now is premature.

CC: @mrl5 (who is working on #197 now) Just to have this recorded in here: > Could even be a security issue to unload LKRG? Actually, yes. If a user...

@mrl5 To your question (even though directed at Adam), I think the pros and cons were not specifically considered at the time. See also the comments at https://github.com/lkrg-org/lkrg/issues/108#issuecomment-968357020

> I wonder if we reasonably can detect whether the system is being shut down, and only unload LKRG when the service is being stopped not as part of system...

@morfikov Thanks, however this does not get us anywhere. Of course, it's about `ExecStop`, however we want LKRG to be unloaded when the service is stopped, just not when it...

@morfikov Anyway, I don't mean to spend your time on (re-)researching this about `shutdown.target` in `Before` now. So if you don't recall, that's fine.

Thanks, @morfikov. Curiously, systemd has `RefuseManualStop`, but here we need "allow only manual stop".