ColabDesign icon indicating copy to clipboard operation
ColabDesign copied to clipboard

asymmetric inputs for `get_con_loss` inside `_loss_binder`

Open pagpires opened this issue 1 year ago • 0 comments

First, thanks for creating this tool!

Is it intentionally to input target_id and binder_id asymmetrically for mask_1d and mask_ib below? https://github.com/sokrypton/ColabDesign/blob/d193e44f77a8f382cdd8fdb49c565c17e61fa13a/colabdesign/af/loss.py#L42-L47

Inside get_con_loss there are are some logical_and operations, and seems whether it's asymmetric depends on the input. Not sure if it's a bug

pagpires avatar Oct 09 '24 04:10 pagpires