sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[CollisionModel] Rename proximity data to contactDistance

Open bakpaul opened this issue 7 months ago • 6 comments

Rename data to match the one in Proximity objects.

[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/195] [ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/165] [ci-depends-on https://github.com/sofa-framework/Regression/pull/82]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

bakpaul avatar Jun 02 '25 15:06 bakpaul

[ci-build][with-all-tests]

bakpaul avatar Jun 03 '25 08:06 bakpaul

I would call it for proximityDistance 🙋

fredroy avatar Jun 04 '25 08:06 fredroy

@EulalieCoevoet what do you think about @fredroy suggestion ?

bakpaul avatar Jun 04 '25 15:06 bakpaul

I prefer contactDistance, to be consistent with ProximityIntersection components: image

And also I find it easier to understand.

EulalieCoevoet avatar Jun 04 '25 15:06 EulalieCoevoet

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

  • Merge or close https://github.com/sofa-framework/BeamAdapter/pull/195 For this build, the following CMake flags will be set -DBEAMADAPTER_GIT_REPOSITORY='https://github.com/sofa-framework/BeamAdapter' -DBEAMADAPTER_GIT_TAG='90679683d160143daa09795a20289679ef4546e5'
  • Merge or close https://github.com/SofaDefrost/ModelOrderReduction/pull/165 For this build, the following CMake flags will be set -DMODELORDERREDUCTION_GIT_REPOSITORY='https://github.com/SofaDefrost/ModelOrderReduction' -DMODELORDERREDUCTION_GIT_TAG='91d87b660e0f6170e8e5d437bf36101673d38e53'
  • Merge or close https://github.com/sofa-framework/Regression/pull/82 For this build, the following CMake flags will be set -DREGRESSION_GIT_REPOSITORY='https://github.com/sofa-framework/Regression' -DREGRESSION_GIT_TAG='71850341addc11e38b4e72850bf8f79da1318148'

sofabot avatar Jun 19 '25 14:06 sofabot

[ci-depends-on] detected during build #8.

To unlock the merge button, you must

  • Merge or close https://github.com/sofa-framework/BeamAdapter/pull/195 For this build, the following CMake flags will be set -DBEAMADAPTER_GIT_REPOSITORY='https://github.com/sofa-framework/BeamAdapter' -DBEAMADAPTER_GIT_TAG='90679683d160143daa09795a20289679ef4546e5'
  • Merge or close https://github.com/SofaDefrost/ModelOrderReduction/pull/165 For this build, the following CMake flags will be set -DMODELORDERREDUCTION_GIT_REPOSITORY='https://github.com/SofaDefrost/ModelOrderReduction' -DMODELORDERREDUCTION_GIT_TAG='91d87b660e0f6170e8e5d437bf36101673d38e53'
  • Merge or close https://github.com/sofa-framework/Regression/pull/82 For this build, the following CMake flags will be set -DREGRESSION_GIT_REPOSITORY='https://github.com/sofa-framework/Regression' -DREGRESSION_GIT_TAG='71850341addc11e38b4e72850bf8f79da1318148'

sofabot avatar Jun 25 '25 02:06 sofabot

[ci-depends-on] detected during build #9.

To unlock the merge button, you must

  • Merge or close https://github.com/sofa-framework/BeamAdapter/pull/195 For this build, the following CMake flags will be set -DBEAMADAPTER_GIT_REPOSITORY='https://github.com/sofa-framework/BeamAdapter' -DBEAMADAPTER_GIT_TAG='e1473b400bb5f032bf5611d8d1d2157a91809929'
  • Merge or close https://github.com/SofaDefrost/ModelOrderReduction/pull/165 For this build, the following CMake flags will be set -DMODELORDERREDUCTION_GIT_REPOSITORY='https://github.com/SofaDefrost/ModelOrderReduction' -DMODELORDERREDUCTION_GIT_TAG='91d87b660e0f6170e8e5d437bf36101673d38e53'
  • Merge or close https://github.com/sofa-framework/Regression/pull/82 For this build, the following CMake flags will be set -DREGRESSION_GIT_REPOSITORY='https://github.com/sofa-framework/Regression' -DREGRESSION_GIT_TAG='71850341addc11e38b4e72850bf8f79da1318148'

sofabot avatar Jul 02 '25 07:07 sofabot

[ci-build][with-all-tests][force-full-build]

fredroy avatar Jul 03 '25 06:07 fredroy

[ci-depends-on] detected during build #10.

All dependencies are merged/closed. Congrats! :+1:

sofabot avatar Jul 03 '25 06:07 sofabot

[ci-depends-on] detected during build #11.

All dependencies are merged/closed. Congrats! :+1:

sofabot avatar Jul 03 '25 06:07 sofabot