sofa icon indicating copy to clipboard operation
sofa copied to clipboard
verified publisher icon sofa-framework

[Core] Fix isSet flag when setting a link to a not-yet created data

Open fredroy opened this issue 1 year ago • 4 comments

In SimpleAPI and SofaPython3 (surely XML too), if a data link is set to a data of a not-yet created BaseObject, isSet is not true.

In the newly created tests, the last one would be false without the fix in BaseData

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

fredroy avatar Oct 23 '24 03:10 fredroy

[ci-build][with-all-tests]

fredroy avatar Oct 23 '24 04:10 fredroy

Is this related to https://github.com/sofa-framework/sofa/pull/4910?

alxbilger avatar Oct 23 '24 07:10 alxbilger

This should fix https://github.com/sofa-framework/sofa/issues/4911

hugtalbot avatar Oct 23 '24 19:10 hugtalbot

Is this related to #4910?

Maybe but It was not my intention 😅 I got the problem in SofaPython3 for our own component.

This should fix #4911

It would have been convenient to have a test related to this problem 👼

fredroy avatar Oct 23 '24 23:10 fredroy

[ci-build][with-all-tests][force-full-build]

fredroy avatar Nov 14 '24 14:11 fredroy