sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[LinearAlgebra] Add CompressedRowSparseMatrixConstraint tests

Open fredroy opened this issue 1 year ago • 3 comments

Tests pulled from https://github.com/InSimo/ISSofa/blob/issofa/framework/framework_test/defaulttype/ConstraintSparseMatrix_test.cpp

Major modifications:

  • bloc -> block
  • some tests fixed (???)
  • removal of MapMapSparse tests

+ Important fix: readLine returns a endIterator if the line index is not correct (as described by the description....)


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

fredroy avatar Oct 02 '24 07:10 fredroy

[ci-build][with-all-tests]

fredroy avatar Oct 02 '24 08:10 fredroy

[ci-build][with-all-tests][force-full-build]

fredroy avatar Oct 18 '24 04:10 fredroy

Intense to review for me but it looks good, and CI says yes

hugtalbot avatar Oct 18 '24 19:10 hugtalbot