sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[Collision] ADD optional viscous friction at sliding contact points

Open aleblanc30 opened this issue 1 year ago • 4 comments

Add a parameter "drag" to the collision response. When two objects slip past each other, a force of magnitude -drag*relative_velocity is applied to the contact points.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

aleblanc30 avatar Sep 12 '24 08:09 aleblanc30

Hi @aleblanc30 A very nice PR for a first PR! Thanks a lot reviews have been shared to you:

MOR plugin need to be fixed (we will take care of it) and take reviews into account regarding the object registration.

hugtalbot avatar Sep 25 '24 08:09 hugtalbot

Thank you @hugtalbot, I'm working on it :-)

aleblanc30 avatar Sep 25 '24 13:09 aleblanc30

Screenshot 2025-06-23 073729

It feels like there is a problem with a merge/rebase somewhere 😅

fredroy avatar Jun 22 '25 22:06 fredroy

Ah ah you're right ! :rofl:

I cleaned up the history.

aleblanc30 avatar Jun 23 '25 12:06 aleblanc30