sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[MechanicalLoad] Factorize damping forcefields

Open hugtalbot opened this issue 1 year ago • 3 comments

Two forcefields were existing and very similar:

  • UniformVelocityDampingForceField : real applied similarly in a isotropic on each dofs (x, y, z)
  • DiagonalVelocityDampingForceField : possibly anisotropic vector of damping coefficient per node

Unify these two with the NodalLinearDampingForceField

One question : which input do we want

  • a real
  • a vector of real (which not existing so far)
  • a vector of Deriv (allowing for anistropic damping while we do not do much anistropy in SOFA)

Remaining TODO

  • [ ] Update all tests
  • [ ] Update all examples

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

hugtalbot avatar Aug 13 '24 19:08 hugtalbot

[ci-build][with-all-tests][force-full-build]

fredroy avatar Aug 14 '24 13:08 fredroy

[ci-build][with-all-tests][force-full-build]

fredroy avatar Aug 14 '24 14:08 fredroy

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

  • Merge or close https://github.com/sofa-framework/SofaPython3/pull/442 For this build, SofaPython3/ExternalProjectConfig.cmake.in will be edited by builders with GIT_REPOSITORY https://github.com/sofa-framework/SofaPython3 GIT_TAG 9f746d4a6c177082b1251c3271cd296c7d18024e

sofabot avatar Aug 14 '24 14:08 sofabot