sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[ODESolver] Explicit link to linear solver

Open alxbilger opened this issue 1 year ago • 4 comments

It basically removes the use of MultiMatrix which hides the use of a LinearSolver. Implicitly, the first linear solver found was used. Now, the LinearSolver can be defined directly in the ODE solver as a Link.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

alxbilger avatar Apr 04 '24 14:04 alxbilger

[ci-build][with-all-tests]

alxbilger avatar Apr 04 '24 19:04 alxbilger

[ci-build][with-all-tests]

alxbilger avatar Apr 05 '24 14:04 alxbilger

Why add a diamond inheritance instead of modifying directly the common parent class ODESolver ?

bakpaul avatar Apr 09 '24 14:04 bakpaul

Because explicit solvers do not necessarily require a linear solver

alxbilger avatar Apr 09 '24 15:04 alxbilger