sofa icon indicating copy to clipboard operation
sofa copied to clipboard
verified publisher icon sofa-framework

[Mass] Replace doUpdateInternal by callback: MeshMatrixMass

Open hugtalbot opened this issue 2 years ago • 13 comments

Needs https://github.com/sofa-framework/sofa/pull/4917 to make all tests pass successfully.

In the spirit of #3900 and following #3924, this PR applies the change on the MeshMatrixMass.

To be noted:

  • the componentState must be added to trigger the callback (done in addMDx(), addMToMatrix, accFromF and buildMassMatrix)
  • this PR does not solve the problem of circular dependency referred in #2173

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

hugtalbot avatar Jun 08 '23 06:06 hugtalbot

trackInternalData to remove

hugtalbot avatar Jun 09 '23 09:06 hugtalbot

[ci-build][with-all-tests]

fredroy avatar Jun 13 '23 06:06 fredroy

Similar feature is merged for the ConstantForceField in #3924. It adds separate callbacks for each data but a hacky flag allows to avoid data cross-dependency by de-activating all inputs non-set at the initialization. It could be done here as well but a more robust implementation (Data, callback) could be found.

Add a unit test to make sure that no data cross-dependency is triggered. Manual test as well.

hugtalbot avatar Apr 03 '24 10:04 hugtalbot

[ci-build][with-all-tests]

hugtalbot avatar Aug 13 '24 08:08 hugtalbot

[ci-build][with-all-tests][force-full-build]

hugtalbot avatar Aug 14 '24 20:08 hugtalbot

[ci-build][with-all-tests][force-full-build]

hugtalbot avatar Aug 21 '24 13:08 hugtalbot

[ci-build][with-all-tests][force-full-build]

hugtalbot avatar Sep 19 '24 10:09 hugtalbot

[ci-build][with-all-tests][force-full-build]

hugtalbot avatar Sep 24 '24 06:09 hugtalbot

I do not get why the regression on the scene EulerExplicitSolver.scn .. ever worked. It seems to diverge on both my current SOFA master and the SOFA release v24.06

hugtalbot avatar Sep 24 '24 06:09 hugtalbot

@hugtalbot I found this: https://github.com/sofa-framework/sofa/issues/2888

alxbilger avatar Oct 01 '24 12:10 alxbilger

[ci-build][with-all-tests][force-full-build]

fredroy avatar Oct 09 '24 05:10 fredroy

@hugtalbot will you generate a new regression for the EulerExplicitSolver ?

fredroy avatar Oct 09 '24 23:10 fredroy

[ci-build][with-all-tests][force-full-build]

hugtalbot avatar Oct 15 '24 12:10 hugtalbot