sofa icon indicating copy to clipboard operation
sofa copied to clipboard

Published 20 hours ago • verified publisher icon sofa-framework

[Topology] Add function in BaseMeshTopology to compute all topology containers

Open epernod opened this issue 2 years ago • 9 comments

  • Rename method initTopology already present in XXSetTopologyContainer classes into initContainers
  • Add virtual method in BaseMeshTopology
  • Add Override method implementation in MeshTopology
  • Fix use case in ParallelBVHNarrowPhase

This should fix #2063

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

epernod avatar Oct 08 '22 13:10 epernod

[ci-build][with-all-tests]

epernod avatar Oct 08 '22 13:10 epernod

[ci-build][with-all-tests]

fredroy avatar Oct 19 '22 04:10 fredroy

TEst to fix

alxbilger avatar Oct 19 '22 09:10 alxbilger

Conflicts to solve @epernod

alxbilger avatar Oct 26 '22 09:10 alxbilger

[ci-build][with-all-tests]

epernod avatar Oct 31 '22 16:10 epernod

@epernod Hello!

alxbilger avatar Jun 14 '23 09:06 alxbilger

[ci-build][with-all-tests]

epernod avatar Apr 09 '24 21:04 epernod

All tests not working are due to input mesh with an inconstant input mesh. Like Quad without edges, or list of quads and edges only on border, etc...

what should we do?

epernod avatar Apr 17 '24 12:04 epernod