sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[Constraint.Lagrangian] Update BilateralInteractionConstraint to support topological changes

Open epernod opened this issue 2 years ago • 3 comments

  • Add method to remove an interaction constraint given the dof index and the input mechanicalObject Id
  • Add 2 Single Links to the topology containers to be set to activate topological changes support.
  • Convert constraint index lists from type::vector<in> to TopologySubsetIndices
  • Add callback on the subsetIndices to track topologcial changes. The callback are added only if valid Topology are found using the SingleLinks
  • Add a demo scene: examples/Components/topology/TopologicalModifiers/RemovingBilateralInteractionConstraint.scn

Video of the Result: https://user-images.githubusercontent.com/21199245/191690072-003eb2c6-f0b9-458b-996b-6c37f3c3cac3.mp4


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

epernod avatar Sep 22 '22 07:09 epernod

In fact would be better to merge PR #3330 and #3331 before this one as they are fixing bugs found while doing this test.

epernod avatar Sep 22 '22 08:09 epernod

[ci-build][with-all-tests]

epernod avatar Oct 07 '22 22:10 epernod

[ci-build][with-all-tests]

epernod avatar Oct 17 '22 10:10 epernod

@alxbilger @damienmarchal fine for you too guys?

hugtalbot avatar Oct 18 '22 13:10 hugtalbot

Crash on RemovingBilateralInteractionConstraint.scn on MacOS

alxbilger avatar Oct 19 '22 10:10 alxbilger

[ci-build][with-all-tests]

hugtalbot avatar Oct 19 '22 10:10 hugtalbot

[ci-build][with-all-tests]

hugtalbot avatar Nov 02 '22 08:11 hugtalbot

[force-full-build][ci-build][with-all-tests]

hugtalbot avatar Nov 02 '22 08:11 hugtalbot

[force-full-build][ci-build][with-all-tests]

epernod avatar Nov 02 '22 13:11 epernod

Relevant test results are correct now, ready.

fredroy avatar Nov 02 '22 23:11 fredroy