sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[Topology] Improve TopologyHandler registration

Open epernod opened this issue 2 years ago • 7 comments

  • Use std::set instead of std::list in TopologyContainer to store TopologyHandler
  • Use bool m_isRegistered to tack info if the topologyHandler is registed inside the TopologyContainer list. Catch return of std::insert to update this bool.
  • Factorize method to link topologyHandler using sofa::geometry::ElementType

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

epernod avatar Sep 05 '22 13:09 epernod

[ci-build][with-all-tests]

epernod avatar Sep 05 '22 13:09 epernod

[ci-build][with-all-tests]

epernod avatar Sep 06 '22 13:09 epernod

[ci-build][with-all-tests]

epernod avatar Sep 23 '22 07:09 epernod

[ci-build][with-all-tests]

epernod avatar Oct 07 '22 23:10 epernod

One test added in the PR is failing --> to be fixed

hugtalbot avatar Oct 12 '22 09:10 hugtalbot

[ci-build][with-all-tests]

epernod avatar Oct 17 '22 10:10 epernod

One unit test is still failing on mac and unbutu ...👺

3271/macos_clang_options_release/src/Sofa/Component/Topology/Container/Dynamic/tests/EdgeSetTopology_test.cpp:352
Expected equality of these values:
  edgeH0->getName()
    Which is: "TopologyDataHandler( VectorSpringForceField )springs"
  "TopologyDataHandler( MeshMatrixMass )edgeMass"

fredroy avatar Oct 17 '22 13:10 fredroy

@fredroy @alxbilger good for you?

hugtalbot avatar Oct 18 '22 13:10 hugtalbot

@hugtalbot, test is fixed somehow so... yes

fredroy avatar Oct 19 '22 00:10 fredroy

There is crashing scene on Windows no?

alxbilger avatar Oct 19 '22 10:10 alxbilger

one which is flashing no? @alxbilger @fredroy ?

hugtalbot avatar Oct 19 '22 11:10 hugtalbot

yes flashing, it is already failing on master sometimes: https://www.sofa-framework.org/dash/?branch=origin/master

epernod avatar Oct 19 '22 17:10 epernod

@hugtalbot 🙆

fredroy avatar Oct 20 '22 00:10 fredroy