sofa
sofa copied to clipboard
[Topology] Improve TopologyHandler registration
- Use std::set instead of std::list in TopologyContainer to store TopologyHandler
- Use bool m_isRegistered to tack info if the topologyHandler is registed inside the TopologyContainer list. Catch return of std::insert to update this bool.
- Factorize method to link topologyHandler using sofa::geometry::ElementType
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if
- it builds with SUCCESS for all platforms on the CI.
- it does not generate new warnings.
- it does not generate new unit test failures.
- it does not generate new scene test failures.
- it does not break API compatibility.
- it is more than 1 week old (or has fast-merge label).
[ci-build][with-all-tests]
[ci-build][with-all-tests]
[ci-build][with-all-tests]
[ci-build][with-all-tests]
One test added in the PR is failing --> to be fixed
[ci-build][with-all-tests]
One unit test is still failing on mac and unbutu ...👺
3271/macos_clang_options_release/src/Sofa/Component/Topology/Container/Dynamic/tests/EdgeSetTopology_test.cpp:352
Expected equality of these values:
edgeH0->getName()
Which is: "TopologyDataHandler( VectorSpringForceField )springs"
"TopologyDataHandler( MeshMatrixMass )edgeMass"
@fredroy @alxbilger good for you?
@hugtalbot, test is fixed somehow so... yes
There is crashing scene on Windows no?
one which is flashing no? @alxbilger @fredroy ?
yes flashing, it is already failing on master sometimes: https://www.sofa-framework.org/dash/?branch=origin/master
@hugtalbot 🙆