sofa icon indicating copy to clipboard operation
sofa copied to clipboard
verified publisher icon sofa-framework

[core] remove shadow variables (modern version)

Open maddin200 opened this issue 3 years ago • 3 comments

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

maddin200 avatar Sep 02 '22 09:09 maddin200

thanks a lot for improving your PR @maddin200 I made some suggestions to improve the readability of the code

FYI you could have updated your original PR #3224 it would avoid closing / reopening PRs

hugtalbot avatar Sep 03 '22 09:09 hugtalbot

changed

maddin200 avatar Sep 03 '22 09:09 maddin200

probably I have no time to test it.

maddin200 avatar Sep 05 '22 11:09 maddin200