sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[core] remove shadow variables

Open maddin200 opened this issue 3 years ago • 2 comments


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

maddin200 avatar Aug 16 '22 14:08 maddin200

Thanks @maddin200 :+1: :+1:

hugtalbot avatar Aug 17 '22 06:08 hugtalbot

Imho we should do those changes first and later change auto.

maddin200 avatar Aug 17 '22 10:08 maddin200

[ci-build][with-all-tests]

alxbilger avatar Aug 24 '22 07:08 alxbilger

@maddin200 OK for us to keep it as is :+1: Could you open a second PR based on this one, where the naming of the variable would be improved and the for loop would be modernized.

Let's keep this one to review until next PR is opened

hugtalbot avatar Aug 24 '22 09:08 hugtalbot

[ci-build][with-all-tests]

fredroy avatar Aug 29 '22 05:08 fredroy

Up @maddin200 :raised_hands:

hugtalbot avatar Aug 31 '22 09:08 hugtalbot

see modern version

maddin200 avatar Sep 02 '22 09:09 maddin200

In #3267

hugtalbot avatar Sep 03 '22 09:09 hugtalbot