sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[objectmodel] Avoid extra copy in DataFileNameVector

Open alxbilger opened this issue 3 years ago • 2 comments
trafficstars

And also clean DataFileName and DataFileNameVector.

DataFileNameVector has been extracted in its own files.

The extra copy came from the DataFileNameVector constructor which took a sofa::type::vector<std::string> but it should take a sofa::type::SVector<std::string>. Therefore, there was an implicit conversion.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

alxbilger avatar Jul 29 '22 09:07 alxbilger

[ci-build][force-full-build][with-all-tests]

fredroy avatar Aug 08 '22 02:08 fredroy

Sorry @alxbilger conflict occurred ! :+1: for the cleaning!

hugtalbot avatar Aug 10 '22 09:08 hugtalbot