sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[all] Do not init twice

Open damienmarchal opened this issue 2 years ago • 4 comments

Entering into init() is only allowed if the component is in a non ready state. Implement basic checking on two problematic component that emits warning/error messages when emitted twice.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

damienmarchal avatar Jun 17 '22 13:06 damienmarchal

[ci-build][with-all-tests]

alxbilger avatar Jun 21 '22 13:06 alxbilger

[ci-build][with-scene-tests]

damienmarchal avatar Jun 21 '22 21:06 damienmarchal

thanks for the PR @damienmarchal interesting we could add the flag for discussion at next dev meeting maybe?

the state "Loading" could be in the constructor of any BaseObject .. to be discussed

hugtalbot avatar Jun 24 '22 09:06 hugtalbot