sofa
sofa copied to clipboard
[SofaCUDA] FIX namespaces
When trying to re-enable SofaCUDA on our Linux CI, I faced some namespace errors due to NG work. Hope my fixes are good.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if
- it builds with SUCCESS for all platforms on the CI.
- it does not generate new warnings.
- it does not generate new unit test failures.
- it does not generate new scene test failures.
- it does not break API compatibility.
- it is more than 1 week old (or has fast-merge label).
Build failure on Ubuntu is weird. Seems related to CGAL but I'm not even sure. Can you check this @hugtalbot ? https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-2935/CI_CONFIG=ubuntu_gcc,CI_PLUGINS=options,CI_TYPE=release/6/console
Build failure on Ubuntu is weird. Seems related to CGAL but I'm not even sure. Can you check this @hugtalbot ? https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-2935/CI_CONFIG=ubuntu_gcc,CI_PLUGINS=options,CI_TYPE=release/6/console
The system probably killed the compilation because it took too many resources. Restart the compilation could maybe make it.
@fredroy @guparan is this PR completely replaced by https://github.com/sofa-framework/sofa/pull/2975 ?
@fredroy @guparan is this PR completely replaced by #2975 ?
Should be
[ci-build][with-all-tests]
[ci-build][with-all-tests]
looks good to me @epernod but not locally tested
I'm gonna double check locally and if it is fine I'll merge