sofa icon indicating copy to clipboard operation
sofa copied to clipboard

[SofaMiscMapping] Support points removal in SubsetMultiMapping

Open alxbilger opened this issue 3 years ago • 1 comments

Following the comments in https://github.com/sofa-framework/sofa/pull/2720, this PR replaces:

  1. https://github.com/sofa-framework/sofa/pull/2720
  2. https://github.com/sofa-framework/sofa/pull/2729

A base class for TopologicalMapping is introduced (BaseTopologicalMapping). It has no link to topologies.

SubsetMultiMapping is now a BaseTopologicalMapping and has MultiLinks for input topologies and output topologies. The consequence is that SubsetMultiMapping gets the propagation of the topological changes through the visitor TopologyChangeVisitor. It does not need any callback and subscribe to any topology.

Note that TopologyChangeVisitor is now called on the root, rather than on the Node of the topology undergoing changes. It's a bit more expansive, but my SubsetMultiMapping is not in the same Node.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

alxbilger avatar Mar 03 '22 11:03 alxbilger

[ci-build][with-all-tests]

fredroy avatar Mar 03 '22 21:03 fredroy