Gábor Sörös

Results 9 comments of Gábor Sörös

The line `CHECK_EQ(distortion_coeffs.size(), 4);` is also problematic because the camera_info can contain more elements. It should say `CHECK_GE(distortion_coeffs.size(), 4);` https://github.com/MIT-SPARK/Kimera-VIO-ROS/blob/master/src/utils/UtilsRos.cpp#L76

@SteveMacenski can you check why all checks have failed? there is actually no problem inside the logs. I do not have ROS2 so if you can, please test my implementation...

hm, I only see that the test of camera_calibration fails, but where can I see the actual error message?

I pulled in the upstream/ros2 but I don't have access to Docker at the moment so i cannot test it locally... but I will find a way

I pulled in the latest upstream and tried the docker container. Colcon test gives a strange error (ModuleNotFoundError) which I don't know how to handle, so I I attach here...

I rebased again on the latest ros2 and I still get an error, but a new one (see below, Enum seems to be missing). I don't know why it worked...

I am just blind and I was inspecting the melodic branch :S So I added now the two missing import lines and github actions run through successfully. Can I ignore...

yes, this still needs to be tested by a volunteer, I do not have ROS2 on my computer at the moment

@JWhitleyWork @pmusau17 I merged the upstream changes