Marcos Del Sol Vives

That merge conflict was caused because he has fixed a bug I also fixed on my own, which was basically that the "addItem" method didn't properly compare stacks (it only...

I've ended up using my own fix, mostly because he forgot to also check the metadata on the remove method, which mine did.

This bug still affects real1.8 branch. As of now, effects which take block type or block metadata aren't working anymore.

I see you are hardcoding a 4K sector for the EN25QX128A. Is there any particular reason for that? The EN25QX128A (unlike the EN25Q128) already has a SFDP with that information,...

Yeah I've read that forum post. But it doesn't really address my two concerns about this patch. Unless I'm mistaken: - EN25Q128 should also have a `SPI_NOR_DUAL_READ`, as it supports...

> Hi, @socram8888 , you know all details about EON flash chips, could you help to create a new PR for EN25QX128A. Thanks. I'd be more than happy to craft...

Looking at the author's GitHub timeline, looks like he's no longer maintaining his projects. Fork time, maybe?

Tests have been fixed in our fork at https://github.com/RigoCorp/html-to-image/

Adding: ``` { selector: 'classProperty', modifiers: ['static', 'readonly'], format: ['UPPER_CASE'], }, ``` Seems to do the job. Again, not sure if this should be added because I am not sure...

Rebase performed