Maksym Sobolyev

Hi @adam-waldenberg, both suggestions have been implemented. Please check and let me know if anything else needs to be done. Thanks!

Hey @twmobius thanks for the follow-up. In general accepting "float" into TimeoutAbsMono() is a wrong direction and a good way to shoot oneself into the foot just masking actual error,...

@twmobius thanks, that's sufficient amount of information for now. I am working on a reproducing the issue here: https://travis-ci.com/github/sippy/voiptests/builds/192232824 Stay tuned.

@twmobius ideed the crash is easily reproducible: https://travis-ci.com/github/sippy/voiptests/jobs/405739060#L2371 Working on a fix.

@twmobius fixes for all 4 timers and RadiusAccounting have landed. I'd appreciate if you run latest code revision 1688c9adb or later and report if any other tracebacks are observed. Thanks!

Looks promising. I don't mind having this as a feature, would you please convert this to a PR? Thanks! -Max On Thu., Oct. 29, 2020, 7:38 a.m. Paris, wrote: >...

@arvoshift @twmobius @arvoshift thanks folks, somehow I've overlooked it. I've reproduced the issue here, so fix is coming soon: https://travis-ci.com/github/sippy/voiptests/jobs/407842818#L2369

Latest for windows I think. 

P.S. I looked at the code briefly and I don't see any validation of the length field(s). Those values just taken verbatim, never compared to the actual packet size. Which...

@gitster thanks, Junio for a review/feedback! > The name of the "ident_action" structure may need rethinking. It appears it _is_ used to specify how the custom "ident" is spelled, so...