Snow Helsing

Results 5 comments of Snow Helsing

test fails, please wait for me fixing it.

> If anything, I'd have guessed force_encoding('binary'). unpack('C*') might be the best way to ensure comparability with any input encoding. I'll try it when I'm free. Thank you for suggestion.

FWI, if new record positioned to the top is desired, should hook the `self.xxx_position ||= :first` in the before_validation block. Because when RankedModel is included(usually at the top of model),...

http://edgeguides.rubyonrails.org/4_0_release_notes.html#active-support-deprecations > BufferedLogger is deprecated. Use ActiveSupport::Logger, or the logger from Ruby stdlib. I simply replaced all `ActiveSupport::BufferedLogger` with `ActiveSupport::Logger`. Because I haven't had time to do the "if..else.." work...

and, in lib/better_logging/better_logging.rb, ln 32, should use `Rails::VERSION::MAJOR` instead of `Rails.version.to_i`, because Rails.version maybe '4.0.0.beta1' https://github.com/snow/better_logging/commit/ac2a741fe1747e9d833e09656fcfb250c0777575