David M. Johnson

Thanks for the PR. There is a large amount of formatting changes in the PR that makes it difficult to see what has changed. Please submit a clean PR that...

Thanks Vineet, this PR looks much better. A better description of this PR would be "Update the Chop testing framework from ElasticSearch 1.4.x/1.7.x to ElasticSearch 5.4.x" because this PR does...

Since the Usergrid project does not use Chop, changes to Chop don't impact Usergrid -- Chop is a separate project that probably shouldn't even be part of the Usergrid codebase...

This pull request does not upgrade Usergrid to use ES 5.4.x, it only upgrades the completely separate Chop testing framework that is not part of Usergrid and is not used...

I cannot confirm because Ihave not attempted to run with ES 5.4.x. Dave On Tue, Jun 27, 2017 at 6:59 AM Vineet Verma wrote: > Hi @snoopdave , > >...

I do not intended to merge this code. I don't think it makes sense to upgrade the Chop testing framework to ES 5 when Usergrid itself only supports ES 1.

I'm not sure why the startup failed for Ganesh (and for me), but I was able to get a successful startup by removing some components that are no longer necessary...