Rich Snapp

Results 17 comments of Rich Snapp

Can confirm, had this issue on my windows machine just now (but not on my mac) and using the install order provided by @Janne252 fixed my local nuxt development server....

I needed to change the single quotes to double quotes for this to work on my windows machine. (single quotes worked fine on OSX) e.g. `"ci": "start-test \"yarn run start\"...

I dunno if this is the same issue, but the error is the same and in our case a circular dependency was causing the error.

@patmmccann yeah, it's something I've suggested in the past. There's some considerations to consider if we did this though, such as what target we compiled for, updates to the build/publish...

@gglas It's not going right now, haha. I reverted my PoC and just submitted generated JS to get the adapter merged; but yes, it is worth discussing next steps I...

@muuki88 i agree, if a re-write of prebid.js were to happen i'd propose that it should be written in typescript. however, the #5001 proposal is essentially for an adapter-less version...

So I dug into this a bit, I think the best approach would be a build-time flag and using the dead-code removal already provided by webpack. I did a little...

@patmmccann as i stated i'm not a huge fan of the comment macros to remove sections of code. i'd prefer using dead-code removal as this allows us to use regular...

@jsnellbaker i don't know specifically who is using the npm build, sorry.

this was the original intention of the `validate-imports` plugin so the change looks good to me as soon as the adapters are updated.