Jacob R

Results 123 comments of Jacob R

@diosmosis Sounds good. I appreciate your input. I was already leaning toward trying to keep it in the `SitesStore`, so I'm glad you had a similar thought. I'll start working...

> It seems, the changes broke the site selector, if there are multiple sites, should be a dropdown. You can see from this screen comparison. Let me know if you...

> > > It seems, the changes broke the site selector, if there are multiple sites, should be a dropdown. You can see from this screen comparison. Let me know...

@peterhashair Thank you for pointing out that issue in the `hasMultipleSites()` function. I will address that.

@peterhashair Thank you again for catching that code issue. There are still quite a few test cases failing, but I'm not seeing any related to my changes. Of course, it's...

@peterhashair Yeah. I guess I shouldn't have used the auto-generated version of that file. I switched it back to the 4.x-dev version and made just enough changes to make the...

H @peterhashair . Thank you again for your help. Is there anything else that you see that needs to be fixed?

> @snake14 looks good to me, just revert the fixture SQL to `4.x-dev`, I think you checkout from `5.x-dev`, once the tests are passed, should be good to merge. @peterhashair...

Thanks @justinvelluppillai . You are correct. It appears that I don't permission to merge this PR.

Hi @mbossaton . Thank you for taking the time to create this issue to suggest a potential improvement. I'm marking this issue to be prioritised by our product team. They...