Jared Ketterer

Results 316 comments of Jared Ketterer

We also need some external lump files to test how they work These can be quite rare afaik, there aren't many in the "MegaTest" `tests/maplist.py`

Still standardising the format of each issue to clearly list games, tools, guide & documentation As well as a common checklist for shipping each test map: * mapper / contributor...

We technically also need test maps for `branches.bspx` `BSPX` data can be appended to either `IdTechBsp[id_software.quake2]` or `QbismBsp[id_software.qbism]` Other `.bsp` formats might support `BSPX` https://github.com/fte-team/fteqw seems to have the best...

#16 having a bunch of very similar minimum viable maps would be very useful for this `mp_lobby.bsp` simple box & light likely won't have any distinct entities or lumps Telling...

Drawing clues from the paths of `.bsp`s will be hugely helpful But we should really build a database of key identifiers (unique entities, struct sizes etc.)

[wfowler1/LibBsp](https://github.com/wfowler1/LibBSP/) also has a fair few autodetect methods for various formats Including some bsp formats we don't support yet... (cod1 demo & stef2 demo) Found 2 cod 1 sp demos...

A lot of Source Engine version conflicts come down to StaticProp version We could write a barebones VBSP inspector to check the SPRP version & size (from `num_props`)

Automated testing for `.as_bytes()` methods will be a big help here Probably something to implement in branch script testing

#112 shows that we need to test all `.as_bytes()` methods, specifically for `SpecialLumpClasses` Explicitly! Not just indirect testing through `.save_as()` Building tests to support `.save_as()` is bringing out the deep...

> `tests/test_save.py` needs to be content aware, otherwise saves must be byte-for-byte refactors to `extensions.diff` should now cover this still need some specialised classes for diffing SpecialLumpClasses but the refactor...