Tiago Conceição

Results 173 comments of Tiago Conceição

Still struggle with this one... `[FieldBitLength(24)] uint FieldName {get; set;}` does not return the correct value from 3 bytes as uint. Any suggestion?

Sure, here my definition: ![devenv_2022-07-23_23-58-18](https://user-images.githubusercontent.com/113281/180625498-778577b9-46df-4fbc-a0af-893ea7d0297e.png) What i get: ![devenv_2022-07-24_00-03-48](https://user-images.githubusercontent.com/113281/180625575-b08d013e-4b43-4481-9bdc-a86426fcad28.png) What i expect: ![010Editor_2022-07-24_00-04-18](https://user-images.githubusercontent.com/113281/180625583-e47e1390-bfa2-4742-92db-041f58010235.png) File is in BIG order and use a ton of uint24

Thanks for looking into it. I've not look at source code, but one thing i always do when working with bytes and convertion is to avoid C# converter functions (`BitConverter`),...

It does not look like a int but with less a possible byte? For example uint24 max value would be 16777215 == 0xFFFFFFFF & 0x00FFFFFF And for Big-endian would not...

To overcome this i have created this class to use BinarySerialization: ```C# public sealed class UInt24BigEndian { [FieldOrder(0)] [FieldCount(3)] public byte[] Bytes { get; set; } = new byte[3]; [Ignore]...

> Working on this now. My plan is to add a configurable comparison operator to the SerializeUntil and ItemSerializeUntil attributes. Perfect :)

`[SerializeUntil(0, ComparisonOperator = ComparisonOperator.NotEqual, LastItemMode = LastItemMode.Defer]` - I think this is a bit confusing we are reverting logic. But a `ComparisonOperator` makes sense on SerializeWhile, defaulting to Equal

> @sn4k3 I agree it's confusing. Unfortunately the current default behavior for SerializeUntil is to discard the terminating value. So in your example, the resulting string would be REVIEW rather...

But the **TerminatedString** flag should append a 00 byte at serialization time right? So far i have this working by using a byte array instead: ```C# /// /// Gets the...

> Similarly I have resorted to using a custom class. Can you share your custom class to fix this?