smuu
smuu
Related issue: https://github.com/celestiaorg/knuu/issues/165
## Features - [ ] https://github.com/celestiaorg/knuu/issues/11 - [ ] https://github.com/celestiaorg/knuu/issues/31 - [x] https://github.com/celestiaorg/knuu/issues/32 - [ ] https://github.com/celestiaorg/knuu/issues/41 - [ ] https://github.com/celestiaorg/knuu/issues/74 - [x] https://github.com/celestiaorg/knuu/issues/78 - [x] https://github.com/celestiaorg/knuu/issues/84 - [ ]...
https://github.com/celestiaorg/knuu/issues/91
Currently, the namespace is `test` if not specified otherwise, using the `KNUU_NAMESPACE` environment variable. See here in the code: https://github.com/celestiaorg/knuu/blob/main/pkg/k8s/k8s.go#L43 Instead of using `test` as default, it knuu should use...
When calling `Start` the code checks if ports and only deploys a service if so. https://github.com/celestiaorg/knuu/blob/920d628be85f2670857a962e78481666994feea2/pkg/knuu/instance.go#L619 In the `Destroy`, we don't have this check. We just call the destroy function....
Errors are not handled for calls of `validatePort` https://github.com/celestiaorg/knuu/blob/920d628be85f2670857a962e78481666994feea2/pkg/knuu/instance.go#L209 https://github.com/celestiaorg/knuu/blob/920d628be85f2670857a962e78481666994feea2/pkg/knuu/instance.go#L224 Add proper error handling.
The `func (i *Instance) GetIP()` has some wrong documentation. This function works in all states. https://github.com/celestiaorg/knuu/blob/09b6f26560582a32cd65fa1007a50a48eb5f7f4d/pkg/knuu/instance.go#L510 https://github.com/celestiaorg/knuu/blob/09b6f26560582a32cd65fa1007a50a48eb5f7f4d/pkg/knuu/instance.go#L509